-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove site globals #15617
base: master
Are you sure you want to change the base?
remove site globals #15617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good PR, some off-topic details blocking merge for now
if (prop && typeof prop === 'object') deepFreeze(prop); | ||
} | ||
Object.freeze(obj); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this new? I can't find where it's used.
: str; | ||
|
||
// does not compare complex objects or non-enumerable properties | ||
export function enumerableEquivalence(a: any, b: any, enforceArrayOrder = true): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find where this is used.
}) | ||
).returnValue === 'yes' | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with the native browser alert and confirm?
Also it probably should be in a different PR
justify-content: end; | ||
gap: 2em; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
htmlText?: string; // content, text will be used as-is | ||
cash?: Cash; // content, overrides htmlText, will be cloned and any 'none' class removed | ||
htmlUrl?: string; // content, overrides htmlText and cash, url will be xhr'd | ||
append?: { node: HTMLElement; where?: string; how?: 'after' | 'before' | 'child' }[]; // default 'child' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this new append.how
doesn't seem to be used anywhere. It still compiles after I remove it.
remove dialog from site, along with a few other junk functions. code splitting obviates manual bundler deduplication