Skip to content

Commit

Permalink
Regold failing tests
Browse files Browse the repository at this point in the history
Now that we have the viscous term strong residual, for the RZ cone
tests, I was able to simply set the AD gold file equal to the non-AD
gold file, which is awesome. As I do not have a SUPG energy equation
formulation for INS (non-AD) I did not attempt to do any equivalency
checking for the energy conservation test, and just re-golded the
CSV file
  • Loading branch information
lindsayad committed Aug 23, 2023
1 parent fdcab4b commit 591913e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@
custom_cmp = 'rz-cone-with-globals.cmp' # To ignore the vector variable components automatically generated by libMesh/ParaView
[]
[ad_rz_cone_no_parts_steady_supg_pspg_second_order]
# TODO: update the gold file once second order derivatives are implemented in libMesh for TypeNTensors
type = 'Exodiff'
input = 'ad_rz_cone_no_parts_steady_stabilized_second_order.i'
exodiff = 'ad_rz_cone_no_parts_steady_stabilized_second_order_out.e'
issues = '#14901'
requirement = 'The system shall be able to solve the steady incompressible Navier-Stokes equations with SUPG and PSPG stabilization and a second order velocity basis using an automatic differentiation, vector variable implementation in an RZ coordinate system while not integrating the pressure term by parts and applying a natural outflow boundary condition.'
custom_cmp = 'rz-cone-with-globals.cmp' # To ignore the vector variable components automatically generated by libMesh/ParaView
[]
[rz_cone_no_parts_steady_supg_pspg_second_order]
type = 'Exodiff'
Expand All @@ -152,12 +152,12 @@
requirement = 'The system shall be able to solve the steady incompressible Navier-Stokes equations with SUPG and PSPG stabilization and a second order velocity basis using a hand-coded Jacobian, standard variable implementation in an RZ coordinate system while not integrating the pressure term by parts and applying a natural outflow boundary condition.'
[]
[ad_rz_cone_by_parts_steady_supg_pspg_second_order]
# TODO: update the gold file once second order derivatives are implemented in libMesh for TypeNTensors
type = 'Exodiff'
input = 'ad_rz_cone_by_parts_steady_stabilized_second_order.i'
exodiff = 'ad_rz_cone_by_parts_steady_stabilized_second_order_out.e'
issues = '#14901'
requirement = 'The system shall be able to solve the steady incompressible Navier-Stokes equations with SUPG and PSPG stabilization and a second order velocity basis using an automatic differentiation, vector variable implementation in an RZ coordinate system while integrating the pressure term by parts and applying a natural outflow boundary condition.'
custom_cmp = 'rz-cone-with-globals.cmp' # To ignore the vector variable components automatically generated by libMesh/ParaView
[]
[rz_cone_by_parts_steady_supg_pspg_second_order]
type = 'Exodiff'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
time,advection,convective_heat_transfer,source,energy_balance
time,advection,convective_heat_transfer,energy_balance,source
0,0,0,0,0
1,0.035399450358858,0.61909901913896,0.65449846949787,-5.9174887212521e-14
1,0.035376853388243,0.61912161610963,-5.5511151231258e-16,0.65449846949787

0 comments on commit 591913e

Please sign in to comment.