Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to the now delete linkml_runtime.utils.ifabsent_functions #325

Merged

Conversation

vincentkelleher
Copy link

@vincentkelleher vincentkelleher commented Jun 27, 2024

This pull-request is necessary for linkml/linkml#2175 as the documentation and metadata has been modified by the fact the linkml_runtime.utils.ifabsent_functions have been deleted.

The new enum default value support has also been documented in this pull-request.

@vincentkelleher
Copy link
Author

I'm getting the rate limiting issue with coverage again.

image

I've disabled the Github CI fail in the case where coverage upload fails to see if it works.

@vincentkelleher
Copy link
Author

I'm getting the rate limiting issue with coverage again.

image

I've disabled the Github CI fail in the case where coverage upload fails to see if it works.

And it works 😅

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentkelleher!

The process for modifying the metadata is a little more involved.

Can you make the PR to this file? https://github.com/linkml/linkml-model/blob/main/linkml_model/model/schema/meta.yaml

We will then take care of propagating the changes back through the copy in runtime

@vincentkelleher
Copy link
Author

Thanks @vincentkelleher!

The process for modifying the metadata is a little more involved.

Can you make the PR to this file? https://github.com/linkml/linkml-model/blob/main/linkml_model/model/schema/meta.yaml

We will then take care of propagating the changes back through the copy in runtime

Hi @cmungall 👋

I've raised linkml/linkml-model#198

@vincentkelleher
Copy link
Author

Hi @cmungall

Could you explain to me what the next steps are now that my pull request on the linkml-model project is validated ? 😇

Vincent Kelleher added 2 commits July 4, 2024 08:36
@vincentkelleher vincentkelleher force-pushed the update_ifabsent_utils_reference branch from 50d5c75 to 7ef6d90 Compare July 4, 2024 06:38
@vincentkelleher
Copy link
Author

Just rebased this branch to include the latest updates from linkml-model:1.8.0 😉

@cmungall cmungall merged commit 984e4b2 into linkml:main Jul 5, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants