Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Fixed mobile web page jump error #2693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented May 28, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

修复移动设备通过会话设置打开默认助手界面后,点击返回跳转至错误页面

A malfunction was identified in the Default Assistant interface, accessible via Session Settings on mobile devices. Upon clicking Back, users were inadvertently directed to an unexpected web page.

📝 补充信息 | Additional Information

Copy link

vercel bot commented May 28, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (b7f4bf6) to head (3893988).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2693    +/-   ##
========================================
  Coverage   93.43%   93.43%            
========================================
  Files         382      382            
  Lines       23629    23629            
  Branches     1718     2646   +928     
========================================
  Hits        22077    22077            
  Misses       1552     1552            
Flag Coverage Δ
app 93.43% <ø> (ø)
server 68.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented May 28, 2024

修复移动设备上点击请求桌面网站后,自动跳转至https://chat-preview.lobehub.com/

原理是啥?为啥会跳到 chat-preview?

OFFICIAL_URL 不能改,也不能用环境变量。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Fixed the problem that after clicking on the mobile device to request the desktop website, it will automatically jump to https://chat-preview.lobehub.com/

What is the principle? Why jump to chat-preview?

OFFICIAL_URL cannot be changed, nor can environment variables be used.

@RubuJam
Copy link
Contributor Author

RubuJam commented May 28, 2024

@arvinxx 我上传了一个视频,另外我也还在了解原因

I uploaded a video, and I still know the reason

@arvinxx
Copy link
Contributor

arvinxx commented May 28, 2024

@RubuJam 我试了下似乎只有 Safari 下有这个问题,Chrome 并不会跳到 preview

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@RubuJam I tried it and it seems that this problem only occurs under Safari. Chrome will not jump to preview.

@RubuJam
Copy link
Contributor Author

RubuJam commented May 28, 2024

@arvinxx 那这个就很奇怪了

That’s weird

@arvinxx arvinxx marked this pull request as draft May 28, 2024 11:19
@RubuJam RubuJam changed the title 🐛 fix: Fixed jump error when requesting desktop website 🐛 fix: Fixed jump error when requesting mobile website Jun 24, 2024
@RubuJam RubuJam changed the title 🐛 fix: Fixed jump error when requesting mobile website 🐛 fix: Fixed mobile web page jump error Jun 24, 2024
@RubuJam RubuJam marked this pull request as ready for review June 24, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants