Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a dedicated card view mode #231

Merged
merged 1 commit into from
Jul 16, 2024
Merged

adds a dedicated card view mode #231

merged 1 commit into from
Jul 16, 2024

Conversation

markconroy
Copy link
Member

Closes #57


Thanks to Big Blue Door for sponsoring my time to work on this.

@ekes
Copy link
Member

ekes commented Jul 8, 2024

Woo... popped in here to see if there was anything backend-ish to check and there ain't so much. It adds to existing sites, but uses the localgov_ name space so that should be safe. So pass on that, but while I'm already here, questions:

I know card display modes are pretty common, is the plan to use it somewhere in the default localgov install? I'd assume that would be the reason to want to add it to core? At the moment it's going to have all the default fields because there's no settings for content types? Is there a plan for where this is going?

@andybroomfield
Copy link
Contributor

Does this actully enable it on anything though? Is it planned to be used anywhere?

@markconroy
Copy link
Member Author

Yes, we should start using it for the featured news at the top of news listings for example.

We could eventually start shipping teaser and card view modes for each of our content types (that can be then used in views or in entity reference fields).

I already have a follow-up issue created in LocalGov Base to add a card template.

Based on the work for elections recently, I can also imagine a "timeline" view mode in our not-too-distant future.

@markconroy
Copy link
Member Author

@andybroomfield @ekes are you okay for us to mark this as 'approved'?

@msayoung any thoughts?

@finnlewis finnlewis merged commit 1e3c35b into 2.x Jul 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add view mode for 'Card'
4 participants