Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autodilation for blends. #236

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

jbkalmbach
Copy link
Member

No description provided.

@jbkalmbach jbkalmbach marked this pull request as ready for review June 25, 2024 20:07
@jbkalmbach
Copy link
Member Author

Closed Loop Results showing that auto dilate performs at least as well as or better than no dilation:

image
image

"""
sourceMaskInit = sourceMask.copy()
blendMaskInit = blendMask.copy()
imageArray = image.image
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider do not have this new variable imageArray or use the image.image.copy() instead.
Since this name is not too long, the followings could be used directly:

blendPix = newSourceMask * image.image

Otherwise, someone might not notice this in the future and modify the value in imageArray, and therefore, touch the original image.image by the accident.
When this happened, it would not be easy to debug.

Thanks!

@jfcrenshaw
Copy link
Collaborator

Closed Loop Results showing that auto dilate performs at least as well as or better than no dilation:

image image

I'm not sure what to make of these plots. What is the difference between the two? Why is autodilate underperforming compared to dilate=4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants