Fixed min pT, vertical range on plots, and stats box #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosedj1 Please fix the stuff that I commented. Also can you fix the indentation? It looks weird on github. |
lucien1011
reviewed
Jul 12, 2018
DarkZ/Skimmer/RecoSkimmer.py
Outdated
| Nmm = 0 | ||
| Nmp = 0 | ||
| Nem = 0 | ||
| Nep = 0 | ||
| lepids = [lep.id for lep in leps] | ||
| for lep_id in lepids: | ||
| if lep_id == -13: | ||
| # lep_ids were initially wrong. E.g. mm was -13. Shouldn't matter in the end. |
There was a problem hiding this comment.
Can you remove this comment, as you have fixed the id already?
Plotter/PlotEndModule.py
Outdated
| @@ -122,6 +122,7 @@ def makeSignalHist(self,collector,plot): | |||
| h.SetLineWidth(5) | |||
| h.SetLineColor(sampleColorDict[sample]) | |||
| h.SetFillColorAlpha(ROOT.kRed,0.) | |||
| h.SetStats(0) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made some comments here and there to myself. I can remove these in the future when doing a pull request.