New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend paddle: switch default line_search_fn of L-BFGS to 'strong_wolfe' #1790

Merged

lululxvi merged 1 commit into lululxvi:master from lijialin03:develop

Jul 1, 2024

Contributor

lijialin03 commented Jul 1, 2024

switch default line_search_fn of L-BFGS to 'strong_wolfe'
'n_iter' in the L-BFGS of paddle and torch will be increased by one at the beginning. Therefore, the original code cannot achieve the expected effect of exiting after training converges because 'prev_n_iter' always equal to 'n_iter - 1' in that line of code. Fixed it in the PR (by the way, for backend torch).


          Backend paddle: switch default line_search_fn of L-BFGS to 'strong_wo…

7138ca5

…lfe'

lululxvi merged commit a856b4e into lululxvi:master

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment