Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes small changes in Makefile(pr #211) #214

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gtisan
Copy link

@gtisan gtisan commented Jul 8, 2024

I didn't know how to change the commit history of pr #211 therefore
I created a new pull request to fix the problem with SDIO.

You can delete old pr #211 or I can do it after review.

@dubhater
Copy link
Collaborator

It still doesn't work. :) I have CONFIG_PCI=y and CONFIG_USB=y, but CONFIG_MMC=m.

@a5a5aa555oo
Copy link

On ArchLinux/Debian ====> CONFIG_MMC=m
On Ubuntu/LinuxMint ====> CONFIG_MMC=y

so ifneq ($(CONFIG_MMC), ) should be better.

@gtisan
Copy link
Author

gtisan commented Jul 14, 2024

Thanks, I did it.

In this repo the firmware for 8822cu(rtw8822c_fw.bin) is older than in linux-firmware.
Is it fine or should we upgrade to the latest firmware ?

@dubhater
Copy link
Collaborator

We should upgrade the firmware.

@a5a5aa555oo
Copy link

a5a5aa555oo commented Jul 15, 2024

I compared the firmware files here with the ones in linux-firmware, and the result is as below:
rtl8822cu_fw.bin: firmware for bt, older than the one in linux-firmware (0xFFB8_ABD3 vs AED6_6DCB)
rtw8723d_fw.bin: identical
rtw8812a_fw.bin: only exist in this repo
rtw8821a_fw.bin: identical
rtw8821c_fw.bin: older than the one in linux-firmware (v24.8 vs v24.11)
rtw8822b_fw.bin: identical
rtw8822c_fw.bin: older than the one in linux-firmware (v9.9.13 vs v9.9.15)
rtw8822c_wow_fw.bin: identical

I can upgrade them and put all the firmware files in a folder called "firmware" if you permit.

@dubhater
Copy link
Collaborator

@a5a5aa555oo Sounds good to me. I think we can delete the Bluetooth firmware because this repository doesn't provide Bluetooth drivers.

@a5a5aa555oo
Copy link

a5a5aa555oo commented Jul 15, 2024

@dubhater I think so,too. I will delete rtl8822cu_fw.bin and add/upgrade all the firmware needed for rtw88, thank you!~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants