Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compiletest_rs for testing various properties of the compiler #107

Closed
wants to merge 11 commits into from

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jan 3, 2022

Similar to #35, except compiletest_rs is less polished than trybuild, so we have to do more work.

On the flip side, this it allows us to test codegen and assembly output, which we will probably need for #104 and others in the future.

See The Guide to Rustc Development for usage.

@madsmtm madsmtm added the enhancement New feature or request label Jan 3, 2022
@madsmtm
Copy link
Owner Author

madsmtm commented Jan 14, 2022

Regarding codegen/assembly: That requires FileCheck, which is a pain! In general, compiletest_rs is not really made for any of the things I'm trying to do here!

I'm strongly considering just going with #35 for the compile-fail tests, and rolling our own thing for testing codegen and assembly, by using the filecheck and cargo_metadata crates instead (see also wasmtime's tests).

@madsmtm
Copy link
Owner Author

madsmtm commented Mar 1, 2022

Replaced by #130

@madsmtm madsmtm closed this Mar 1, 2022
@madsmtm madsmtm deleted the compile-tests branch March 1, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant