Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to work RECHECK_SYNC_BACKEND correctly #872

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

makenowjust
Copy link
Contributor

Close #870

Changes

  • Fix to work RECHECK_SYNC_BACKEND correctly
    • A break for switch-case is missing. It is easy mistake.
  • Add a test case for checking whether synckit function has been called.

Close #870

Add a test case for checking whether `synckit` function has been called.
@makenowjust makenowjust added the fix Fixes label May 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Merging #872 (3cd1173) into main (4c51c22) will decrease coverage by 1.70%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   99.05%   97.35%   -1.70%     
==========================================
  Files          69       13      -56     
  Lines        3066     1098    -1968     
  Branches      537      180     -357     
==========================================
- Hits         3037     1069    -1968     
  Misses         29       29              
Impacted Files Coverage Δ
packages/recheck/src/main.ts 100.00% <100.00%> (ø)

... and 56 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@makenowjust makenowjust merged commit 678746c into main May 1, 2023
@makenowjust makenowjust deleted the check-sync-backend branch May 1, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative with timeout
2 participants