Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stevenage gov uk #2217

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

adam-prickett
Copy link
Contributor

Fixes #1997

Stevenage has moved to Granicus and so this fix breaks existing implementations, instead requiring a UPRN over a postcode and property number.

The code was largely borrowed from highland_gov_uk

@5ila5
Copy link
Collaborator

5ila5 commented Jul 4, 2024

Thanks for your contribution.

I just did some reformatting and ran the ./update_docu_links.py script

@5ila5 5ila5 merged commit 41aa829 into mampfes:master Jul 4, 2024
1 check passed
@jamesmyatt
Copy link
Contributor

jamesmyatt commented Jul 5, 2024

Thank you for this.

If highland_gov_uk also uses Granicus, is it worth trying to extract a common structure?

@adam-prickett
Copy link
Contributor Author

Thank you for this.

If highland_gov_uk also uses Granicus, is it worth trying to extract a common structure?

Potentially, however Granicus appears to be a frontend for different services behind the scenes and so this implementation required an extra network call to obtain a token for the waste management service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stevenage UK has changed service
4 participants