Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more custom modes #1022

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Add more custom modes #1022

merged 7 commits into from
Jun 28, 2024

Conversation

mhsattarian
Copy link
Contributor

@mhsattarian mhsattarian commented Nov 24, 2020

Some custom modes I created are added to the list in MODES.md file.
here is a preview:

@mhsattarian mhsattarian changed the title Add Snapping Mode to custom modes Add custom modes Nov 29, 2020
docs/MODES.md Outdated Show resolved Hide resolved
docs/MODES.md Outdated Show resolved Hide resolved
@mhsattarian
Copy link
Contributor Author

Sorry for making this PR pop up again, I just realized I'd forgotten to resolve changes suggested by @clementmas.

@mhsattarian
Copy link
Contributor Author

I've added one more mode I created recently.
and can this be finally merged? this PR has been open for around 2 years!

@mhsattarian mhsattarian changed the title Add custom modes Add more custom modes Nov 27, 2022
@3zzy
Copy link

3zzy commented Mar 11, 2024

@mhsattarian Great work! Sad that its not been merged yet :(

@mhsattarian
Copy link
Contributor Author

Thanks @3zzy, I don't know why either. it's taking so long that I don't work on GIS-related applications anymore!

I really like and respect the Mapbox team's work and effort. I don't know why such a useful project has such slow progress.

@stepankuzmin stepankuzmin requested a review from a team as a code owner June 28, 2024 15:44
Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @mhsattarian!

@stepankuzmin stepankuzmin merged commit 5baf476 into mapbox:main Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants