Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate switching between hot and cold sources #1026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vhautsal
Copy link

@vhautsal vhautsal commented Dec 2, 2020

Switching between two sources causes severe flickering and there seems to be no performance advantage at least in our use case.

Related issues:

#871
#916

This switching causes severe flickering and there seems to be no
performance advantage at least in our use case.

See:

<mapbox#871>
<mapbox#916>
@usb248
Copy link

usb248 commented Feb 2, 2021

It reduces the number of layers in the map. In my case, i would say that it even improves performance ! Thanks @vhautsal

@nicoluce
Copy link

This solves a flicker issue I was having. Hope it gets merged soon 🎉

@stepankuzmin
Copy link
Contributor

Adding for reference #296

@stepankuzmin
Copy link
Contributor

stepankuzmin commented Jan 30, 2023

Hi @vhautsal,

Thanks for the contribution, and sorry for the delayed response! Could you please rebase on top of the main branch to see if the changes pass the CI?

@harryjms
Copy link

We are facing flicker issue also; would be great to get this merged! @vhautsal @stepankuzmin

@Bryce-Davidson
Copy link

any update on this?

@harryjms
Copy link

Bump - we need this fix in please. The flickering of the map caused by the issue is not good

@spaciandd
Copy link

Please do merge it why delaying, app does not look good with flickering.

@harryjms
Copy link

nudge

@LukasGrubis
Copy link

Hi @vhautsal Any update on this PR?

@vhautsal
Copy link
Author

vhautsal commented Aug 6, 2024

Unfortunately there's not much I can do. I synced my branch with upstream a year ago, but nothing happened then. Apparently there are some new conflicts now, but after nearly four years of waiting, I'm not interested in trying to keep up unless some Mapbox API change forces us to update. @LukasGrubis @stepankuzmin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants