Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize 2024 #1242

Merged
merged 20 commits into from
Jun 28, 2024
Merged

Modernize 2024 #1242

merged 20 commits into from
Jun 28, 2024

Conversation

stepankuzmin
Copy link
Contributor

@stepankuzmin stepankuzmin commented Jun 27, 2024

  • Switch to ESM
  • Switch to NPM instead of Yarn
  • Switch to native Node test runner
  • Drop the buble compiler and switch to the esbuild
  • Drop xtend, use Object.assign instead
  • Drop lodash.isequal, use fast-deep-equal instead
  • Use vite for the local development
  • Update the debug/ page: use GL JS and GL Geocoder from NPM so we can keep them up to date with Dependabot

The minified bundle size dropped from 80K to 68K.

The benchmarks primarily use the previous setup.

@stepankuzmin stepankuzmin requested a review from a team as a code owner June 27, 2024 12:38
@stepankuzmin stepankuzmin changed the title Switch to esbuild Modernize 2024 Jun 27, 2024
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Why do we need ESBuild though if we still use Rollup?

@stepankuzmin
Copy link
Contributor Author

You are right, we don't need to transpile with esbuild for older browsers anymore 👍

bench/README.md Outdated Show resolved Hide resolved
@stepankuzmin stepankuzmin force-pushed the small-refactor branch 2 times, most recently from d191167 to 9da02f4 Compare June 27, 2024 15:14
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Something I've been doing recently is also removing tape and nyc in favor of native Node test runner and coverage — see if it makes sense to do so here, but not too important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants