Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fill-outline-color with feature-state #4241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qpincon
Copy link

@qpincon qpincon commented Jun 6, 2024

Launch Checklist

fill-outline-color property using feature-state is broken. See #4234.

This PR only includes a failing test so far

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.98%. Comparing base (d919ba3) to head (ee88c3a).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4241       +/-   ##
===========================================
- Coverage   87.73%   71.98%   -15.75%     
===========================================
  Files         242      241        -1     
  Lines       33081    33077        -4     
  Branches     2160     1419      -741     
===========================================
- Hits        29023    23810     -5213     
- Misses       3088     8023     +4935     
- Partials      970     1244      +274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants