Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid including MSW in the bundle - option 1 #77

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jun 9, 2024

Related marmelab/react-admin#9908

This PR avoid including MSW in the bundle by not using anything from msw in FakeRest code.
However, the setup is more cumbersome

@@ -1,12 +1,12 @@
{
"name": "fakerest",
"version": "3.5.0",
"version": "4.0.0-beta.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock file wasn't updated at release time

@djhi djhi changed the title Avoid including MSW in the bundle Avoid including MSW in the bundle - option 1 Jun 9, 2024
@fzaninotto fzaninotto added this to the 4.0.0 milestone Jun 10, 2024
@fzaninotto fzaninotto merged commit b228c83 into master Jun 10, 2024
3 checks passed
@fzaninotto fzaninotto deleted the fix-bundle branch June 10, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants