Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix identifiers parsing #79

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix identifiers parsing #79

merged 1 commit into from
Jun 17, 2024

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jun 12, 2024 •
edited
Loading

Problem

FakeRest returns 404 for all requests targeting an item with a numeric identifier.

Solution

image

Fix the RegExp and add tests

@djhi djhi added the RFR Ready For Review label Jun 12, 2024
@djhi djhi requested a review from fzaninotto June 12, 2024 19:08
@fzaninotto fzaninotto merged commit 77ff0ac into master Jun 17, 2024
3 checks passed
@fzaninotto fzaninotto deleted the fix-id-detection-and-parsing branch June 17, 2024 08:05
@fzaninotto fzaninotto added this to the 4.0.1 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djhi @fzaninotto