Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #418

Open
wants to merge 101 commits into
base: master
Choose a base branch
from
Open

Conversation

Patryk-Buczkowski
Copy link

@Patryk-Buczkowski Patryk-Buczkowski commented May 27, 2024

Copy link

@nataliaklonowska nataliaklonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, so re-request a review when you have a finished part that you want to be checked :)

@Patryk-Buczkowski
Copy link
Author

Patryk-Buczkowski commented Jul 16, 2024

Hello, here is some things to fix:

  1. Recommended products not shows at accessories product cards
    2.Center your h1,h2, I think its will looks better, 3.If you want you can add your theme style button to header 4.Make changes in your dark theme its looks bad
    5.At some products cards if you choosing options like color or capacity, web site stops work(accesories)
    6.When you adding products in product cart (clicking + or - button) it starts changing position.
    7.Make contacts page with your info

Can You show me point 6?

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point 6 meant that when you change amount of products in cart it's value change and with it it's width and it affect the position what you can see even for number 2 but it's more visible e.g 100:
image

@Patryk-Buczkowski
Copy link
Author

Contacts i will add for sure when i create account on linkedin.

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve all comments below

@natalia-klonowska
Copy link

  • center page content
    image

@natalia-klonowska
Copy link

  • you should have max width at 1200px for all pages
    image
    image

@natalia-klonowska
Copy link

natalia-klonowska commented Jul 18, 2024

  • you should be able to remove product from basket by clicking button again
    image

@natalia-klonowska
Copy link

  • To return to the previous page, you need to use the back button twice and browser don't remember more than last visited page
  • on any product page it's name should be active in breadcrumbs
    image

@natalia-klonowska
Copy link

natalia-klonowska commented Jul 18, 2024

  • all clickable elements should have pointer and selected elements should be marked
    image
    image
    image

@natalia-klonowska
Copy link

  • make sure to always have some elements on recommend section (if list is empty have some default)
    image

@natalia-klonowska
Copy link

when product color name consists of more than one word and you try to change capacity, wrong word is changed and page can't load (and if this happens it should redirect to a 'Page Not Found' instead)
image
image
image

@Patryk-Buczkowski
Copy link
Author

Patryk-Buczkowski commented Jul 18, 2024

image
on figma in breadCrumb product name is grayedout

Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is to little space between logo and navbar
    image
  • there is mismatch in colors of the titles
    image
  • Banner images change when you hit mobile breakpoints (don't know if this is intended)
    image
  • Slider overflows that 1200px of the layout
    image

@Zibi95
Copy link

Zibi95 commented Jul 19, 2024

when you hit 1200px breakpoints weird stuff happens on category section
image

@Zibi95
Copy link

Zibi95 commented Jul 19, 2024

The banner slider looks to small when compared to the big title
image

@Patryk-Buczkowski
Copy link
Author

Banner images change when you hit mobile breakpoints (don't know if this is intended)
yes, it is ;)

@Zibi95
Copy link

Zibi95 commented Jul 19, 2024

  • Those buttons should have the same height as images also i think that the radius is to big and those buttons doesnt fit
    image

  • You should be able to decide how many cards you show on given breakpoint and then lower it down as you screen shrinks
    image

  • These gaps are huge
    image

@Zibi95
Copy link

Zibi95 commented Jul 19, 2024

  • on every view max width of the view i set to 1136px for desktop
    image

@Zibi95
Copy link

Zibi95 commented Jul 19, 2024

Those arrows in breadcrumbs are huge compared to other elements also color is different then on designs
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants