fileservice: limit the number of concurrent object storage operations to 100 #17330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrix-meow
added
size/S
reusee
changed the title
… to 100 fileservice: set maxConnsPerHost to 100 fileservice: fix http client in AwsSDKv2 fileservice: disable aws sdk client side rate limiter fileservice: add objectStorageSemaphore
reusee
changed the title
matrix-meow
added
size/M
fengttt
reviewed
Jul 6, 2024
The MaxConnsPerHost option of the HTTP client doesn't limit the request concurrency, so a true semaphore for the object storage interface is required. |
fengttt
approved these changes
Jul 6, 2024
reusee
added a commit
to reusee/matrixone
that referenced
this pull request
Jul 7, 2024
…s to 100 (matrixorigin#17330) 1000 is too high. Approved by: @fengttt
reusee
added a commit
to reusee/matrixone
that referenced
this pull request
Jul 10, 2024
…s to 100 (matrixorigin#17330) 1000 is too high. Approved by: @fengttt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #17329
What this PR does / why we need it:
1000 is too high.