[pick to 1.2] fix a bug that process's cancel not match to its context #17349
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schen
requested review from
XuPeng-SH,
aunjgr,
ouyuanning and
badboynt1
as code owners
m-schen
changed the title
XuPeng-SH
approved these changes
Jul 5, 2024
badboynt1
approved these changes
Jul 5, 2024
sukki37
approved these changes
Jul 5, 2024
sukki37
added a commit
to sukki37/matrixone
that referenced
this pull request
Jul 7, 2024
…s context (matrixorigin#17349)" This reverts commit 1624bf1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
https://github.com/matrixorigin/MO-Cloud/issues/3512
#17226
What this PR does / why we need it:
修复了一个没有给process的cancel方法赋值，以及cancel方法与传入的ctx不对应导致的pipeline无法被正常杀死的问题。