Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pick to main] fix Compile clear() bug. #17353

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

m-schen
Copy link
Contributor

@m-schen m-schen commented Jul 6, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #17350

What this PR does / why we need it:

the clear method of the Compile structure ,which will be called after query done, should not modify the internal properties of the proc, because this attribute is directly passed in from the outside. When a query fails and a retry occurs, this attribute will still be used.

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Jul 6, 2024
@mergify mergify bot added the kind/bug Something isn't working label Jul 6, 2024
@m-schen m-schen changed the title [pick to main] fix Compile reset() bug. [pick to main] fix Compile clear() bug. Jul 6, 2024
@mergify mergify bot merged commit 53fd3a5 into matrixorigin:main Jul 7, 2024
16 of 18 checks passed
@m-schen m-schen deleted the fix-main-17350 branch July 10, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS Denotes a PR that changes [1, 9] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants