Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : still check dup even if the value is generated by incrservice #17361

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

jensenojs
Copy link
Contributor

@jensenojs jensenojs commented Jul 7, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #16493

What this PR does / why we need it:

Before 16493 is resolved, it is risky to cancel deduplication

@mergify mergify bot added the kind/bug Something isn't working label Jul 7, 2024
@jensenojs
Copy link
Contributor Author

image

先确保值是由increservice生成的时候, 也仍然开启去重机制, 等所有事情都讨论干净了, 再打开.

@matrix-meow matrix-meow added the size/XS Denotes a PR that changes [1, 9] lines label Jul 7, 2024
@mergify mergify bot merged commit 0b4a2fe into matrixorigin:main Jul 8, 2024
18 checks passed
@jensenojs jensenojs deleted the quick_fix branch July 8, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS Denotes a PR that changes [1, 9] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants