[bug] stats: fix hang issue #17364
Merged
[bug] stats: fix hang issue #17364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuPeng-SH
approved these changes
Jul 7, 2024
sukki37
approved these changes
Jul 7, 2024
sukki37
pushed a commit
that referenced
this pull request
Jul 9, 2024
When force to trigger the stats update, which will hang when the channel is full, we should unlock first because another goroutine which fetches items from the channel holds the lock. Approved by: @XuPeng-SH, @sukki37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #17365
What this PR does / why we need it:
When force to trigger the stats update, which will hang when the channel
is full, we should unlock first because another goroutine which fetches
items from the channel holds the lock.