Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] eip2539 public interface #14

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prestwich
Copy link

@prestwich prestwich commented Sep 21, 2020

Largely a find+replace port of the existing eip2537 public interface.

This branch includes changes to the B coefficient constants to match the zexe implementation

Outstanding issue:

  • 3 tests are flaky.
    • public_interface::eip2539::test::dump_vectors_into_fuzzing_corpus
      • a csv issue
    • public_interface::eip2539::test::run_g1_add_on_vector
      • a csv issue
      • passes when running the test in isolation or running on --test-threads 1
    • public_interface::eip2539::test::generate_negative_test_pairing_invalid_subgroup
      • gives NotInField errors when making random Fp

@prestwich
Copy link
Author

Was drafting a comment and accidentally closed instead 🙄

Although most of the functionality is working, I haven't made any progress on the tests. I have draft integration branches with OE and Nethermind, but I'm reluctant to push them without passing tests. Any points on the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant