Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update features & some fixes #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dzejkop
Copy link

@Dzejkop Dzejkop commented Jan 28, 2022

Update features to be compatible with nightly rust.

Also fixes compilation errors that occurred if asm was enabled.

@shamatar
Copy link
Member

shamatar commented Feb 7, 2022

What are those features exactly about? I can in principle try to work around them somehow with extra effort in procmacro, and then it will work in stable

@Dzejkop
Copy link
Author

Dzejkop commented Mar 21, 2022

What are those features exactly about? I can in principle try to work around them somehow with extra effort in procmacro, and then it will work in stable

At some point the asm feature got split into these 2 the asm_sym and asm_const and they refer to operands sym <path> and const <expr> respectively.

The details are beyond me, but without this change I was unable to use this crate on the current version of Rust.

@citizen-stig
Copy link

citizen-stig commented May 12, 2022

@shamatar Hello!
Do you need any more details from @Dzejkop ?

Our project got around 30% performance improvement with this feature enabled, so this can be a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants