Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATED: updated_priority=1 option does not work #1087

Open
ifeldshteyn-emc opened this issue Jun 24, 2024 · 5 comments · May be fixed by #1091
Open

UPDATED: updated_priority=1 option does not work #1087

ifeldshteyn-emc opened this issue Jun 24, 2024 · 5 comments · May be fixed by #1091

Comments

@ifeldshteyn-emc
Copy link

ifeldshteyn-emc commented Jun 24, 2024

UPDATE: Code and Documentation has a typo! The command is update_prioity and should be update_priority

This needs to be updated

"updated_prioity": NewStringSet(eventUpdatedPriority), // changes in priority

image

I am on the latest version of the plugin 4.1.1 and mattermost is 9.5.4. I notice that updated_priority=1 does not seem to trigger the plugin updates. I am following these instructions --> https://docs.mattermost.com/integrate/jira-interoperability.html

My trigger is is PROJECT=XXX and issue CREATED/UPDATED.

https://XXXXXXXX.com/plugins/jira/webhook?channel=test&secret=YYYYYYYY&team=technology&updated_priority=1

This does not trigger an update in mattermost when I change priority. I confirmed an update is sent by jira and the json payload is

"changelog": {
"id": "1294695",
"items": [
{
"field": "priority",
"fieldtype": "jira",
"from": "2",
"fromString": "Critical",
"to": "3",
"toString": "Major"
}
]
}

I did a test with various settings (labels, description, summary, priority...).

Ex:
https://XXXXXXXX.com/plugins/jira/webhook?channel=test&secret=XXXXXX&team=technology&updated_labels=1&updated_description=1&updated_summary=1&updated_priority=1

All of them work except priority.

I have a workaround hack where I use updated_all=1 . It captures priority changes but I would prefer to only be updated on priority updates. Any ideas what I can do?

Thanks!

@mickmister
Copy link
Member

Hi @ifeldshteyn-emc, thanks for filing this issue. Would you be up for fixing the issue if you are able to do so? Otherwise we'll take a look at the issue in our normal triage process. Thanks

@ifeldshteyn-emc
Copy link
Author

Hi @ifeldshteyn-emc, thanks for filing this issue. Would you be up for fixing the issue if you are able to do so? Otherwise we'll take a look at the issue in our normal triage process. Thanks

It's a typo in the code and documentation. Just rename prioity to priority . I don't think I have perms to raise PRs?

@mickmister
Copy link
Member

It's a typo in the code and documentation. Just rename prioity to priority

Awesome work!! Thank you @ifeldshteyn-emc!

I don't think I have perms to raise PRs?

You should be able to fork the repo and make the changes there to submit a PR. Are you up for doing this?

@ifeldshteyn-emc ifeldshteyn-emc changed the title updated_priority=1 option does not work UPDATED: updated_priority=1 option does not work Jun 24, 2024
@ifeldshteyn-emc
Copy link
Author

ifeldshteyn-emc commented Jun 24, 2024

I'd love to but I can't do it here due to restrictions. It's just an easy fix. Also important note - the DOCUMENTATION needs to be updated as well.

@mickmister
Copy link
Member

@ifeldshteyn-emc Does the feature work without the fix if you use updated_prioity? We can add the fix, but we should probably also keep the old functionality as well for backwards compatibility, as some systems may already be using that typo spelling if it works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Submitted / In Review
Development

Successfully merging a pull request may close this issue.

2 participants