Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1087] Add "updated_priority" event param for legacy webhooks #1091

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

raghavaggarwal2308
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 commented Jun 28, 2024

Summary

What to test:

  • Users are getting notified for priority change event in for both event params i.e. "updated_priority" and "updated_prioity"

How to test:

  • Install a Jira instance on you MM
  • Do not connect your account
  • Setup a legacy webhook
  • Update the priority of any ticket on Jira

Ticket Link

Fixes #1087

@raghavaggarwal2308 raghavaggarwal2308 self-assigned this Jun 28, 2024
@raghavaggarwal2308 raghavaggarwal2308 changed the title [MM-554] Add "updated_priority" event param for legacy webhooks [GH-1087] Add "updated_priority" event param for legacy webhooks Jun 28, 2024
@mickmister
Copy link
Member

mattermost/docs#7238 probably should have been left open until we release this change, but it's probably not a big deal in this case. Just something to keep in mind. You can use the Do Not Merge PR label in this case

@@ -29,6 +29,7 @@ var eventParamMasks = map[string]StringSet{
"updated_description": NewStringSet(eventUpdatedDescription), // issue description edited
"updated_labels": NewStringSet(eventUpdatedLabels), // updated labels
"updated_prioity": NewStringSet(eventUpdatedPriority), // changes in priority
"updated_priority": NewStringSet(eventUpdatedPriority), // changes in priority
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to include a comment on the line above, saying we're keeping it around for backwards compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickmister Added the comment

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jul 4, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit e89cdae into master Jul 12, 2024
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-1087 branch July 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPDATED: updated_priority=1 option does not work
4 participants