-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-996]: removed jwt instance from setup autocomplete #1092
Conversation
@Kshitij-Katiyar Are there any remaining references to cloud or JWT? |
@Kshitij-Katiyar I think we need to remove the command from help command response as well |
@mickmister Removed jwt/cloud from helpText and instance autocomplete help text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above PR has been tested for the following scenario:
- Tested the JWT/Cloud instance type in any command/autocomplete, i.e. install, uninstall, help etc
The PR was working fine for the above mentioned condition, LGTM. Approved
Summary
Remove the "cloud" JWT instance type from install, uninstall paths & help text.
What to test
Check for JWT/Cloud instance type in any command/autocomplete, i.e. install, uninstall, help etc
Existing
Updated
Issue
Fixes #996