Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-996]: removed jwt instance from setup autocomplete #1092

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Jun 28, 2024

Summary

Remove the "cloud" JWT instance type from install, uninstall paths & help text.

What to test

Check for JWT/Cloud instance type in any command/autocomplete, i.e. install, uninstall, help etc

Existing

Screenshot from 2024-06-28 21-06-15
help-text-old
instance-install-old

Updated

Screenshot from 2024-06-28 20-58-42
help-text-new
instance-install-new

Issue

Fixes #996

@mickmister
Copy link
Member

@Kshitij-Katiyar Are there any remaining references to cloud or JWT?

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jul 4, 2024
@raghavaggarwal2308
Copy link
Contributor

@Kshitij-Katiyar I think we need to remove the command from help command response as well

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar Are there any remaining references to cloud or JWT?

@mickmister Removed jwt/cloud from helpText and instance autocomplete help text

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mickmister mickmister merged commit 571929f into mattermost:master Jul 10, 2024
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-996 branch July 10, 2024 08:32
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above PR has been tested for the following scenario:

  • Tested the JWT/Cloud instance type in any command/autocomplete, i.e. install, uninstall, help etc

The PR was working fine for the above mentioned condition, LGTM. Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "cloud" JWT instance type from any install paths
6 participants