Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for LinkType.setOutputType #389

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lacinoire
Copy link

Hey 😊
I want to contribute a test.
Curious to hear what you think!

(I wrote this test as part of a research study at TU Delft. Find out more)

Comment on lines 71 to 72
final OutputTypeEnum pluginType = new OutputTypeEnum();
pluginType.setValue("executable");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pluginType is not used as part of test for null, unecessary step

@lacinoire
Copy link
Author

Hey @GregDomjan,

Thank you for the review 🙂
I removed the pluginType variable.

Hope the appveyor build goes through now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants