Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo wheel_odometry.cpp and mavros_plugins.xml #1914

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix typo wheel_odometry.cpp and mavros_plugins.xml #1914

merged 2 commits into from
Oct 26, 2023

Conversation

Moma98
Copy link
Contributor

@Moma98 Moma98 commented Oct 24, 2023

fix typo

@Moma98 Moma98 changed the title Update wheel_odometry.cpp fix typo wheel_odometry.cpp and mavros_plugins.xml Oct 24, 2023
vooon
vooon approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML should be re-generated with cog. Script inside it parses plugin cpp comment and extract definition from it.

But okay, i'll do that. LGTM, Thanks!

@vooon vooon added this to the Version 2.7 milestone Oct 26, 2023
@vooon vooon merged commit 1a0bfc6 into mavlink:ros2 Oct 26, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vooon vooon vooon approved these changes

Assignees
No one assigned
Labels
extras fix ros2
Projects
None yet
Milestone
Version 2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Moma98 @vooon