Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration files in launch directory #1916

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

hasanosman601
Copy link

Removed '/**' in namespace/node_name of parameters in configuration files that located under ./mavros/launch/ directory

This commit modifies the configuration files in the launch directory of the MAVROS package. The '/**' in namespace/node_name of parameters were removed to ensure proper configuration. The specific changes were made in these files:
./mavros/launch/apm_config.yaml
./mavros/launch/apm_pluginlists.yaml
./mavros/launch/px4_config.yaml
./mavros/launch/px4_pluginlists.yaml

- Removed '/**' in namespace/node_name of parameters in configuration
  files that located under ./mavros/launch/ directory

This commit modifies the configuration files in the launch directory of the MAVROS package.
The '/**' in namespace/node_name of parameters were removed to ensure proper configuration.
The specific changes were made in thes files:
    ./mavros/launch/apm_config.yaml
    ./mavros/launch/apm_pluginlists.yaml
    ./mavros/launch/px4_config.yaml
    ./mavros/launch/px4_pluginlists.yaml
@hasanosman601
Copy link
Author

this PR related to #1912 issue

@vooon
Copy link
Member

vooon commented Oct 26, 2023

Please try approach from #1915

@hasanosman601
Copy link
Author

Please try approach from #1915

this approach didn't work for me, all parameters still take default values

@vooon
Copy link
Member

vooon commented Oct 29, 2023

Strange. Soryr, what ros2 release you're on?

@hasanosman601
Copy link
Author

@vooon Foxy release because I'm using ubunut20, but I looked at the documentation for both the Foxy and Humble release about parameters as they have the same documentation so I don't know if the issue is related to the Ros2 distribution I'm using

@vooon
Copy link
Member

vooon commented Oct 31, 2023

@hasanosman601 that's unclear, but some features changes quite hard comparing to older releases.

@hasanosman601
Copy link
Author

@vooon ok, I'll keep this change since it works for me on Foxy release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants