Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/better alias generator #74

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Vyvy-vi
Copy link

@Vyvy-vi Vyvy-vi commented Dec 31, 2020

Description:

Issue #1 discussed on 2 main improvements to be made:

  • Improve alias generator algorithm
  • Improve the data-classifier lists
    This PR splits the lists into more DESCRIPTORS, in order to generate more customised names, moreover, this aims at cleaning up the data a bit, and create a more inclusive classifier dataset. The algorithm has been slightly customised and a new parameter has been added, to cap the max_length at random. (still under work)

Q) Would this new param change production in anything else?
Ans- No. The parameter has a default value, thus there won't be any issues.

Q) Why split descriptors into multiple parts?
Ans-

  • It would be easier for contributors to add similar descriptors, to further customise the name-list
  • This slightly builds upon the previous algorithm, since the split descriptors result in more iterations since now both the descriptor types can be selected together with a name
  • Makes room for further customisations with different types of descriptors

Q) Why is some of the code in this PR, not clean?
Ans- This PR is a draft PR. Once it's ready for review, the code would be cleaned up.

Q) Why is there a commit from ImgBot here?
Ans- ImgBot is an automation that runs on all of my repos.. It optimised the images in the repo... [my bad 馃槄 ]
Though, it didn't affect image quality or any of the code, so things should be fine 馃憤

Q) Why is this a draft?
Ans- There are still some improvements left to make.

This PR aims to:

  • Make the alias generator classifiers less gender-selective
  • Improve upon the alias-generator algorithm
  • Improve on the classifier lists

Related issue:

Issue #1

Sample screenshots:

Screenshot 2020-12-31 at 10 33 55 PM

STATUS: Draft

ImgBotApp and others added 5 commits December 29, 2020 14:32
*Total -- 1,060.84kb -> 1,039.80kb (1.98%)

/static/gifs/giphy-downsized.gif -- 404.34kb -> 383.78kb (5.09%)
/static/startchat.jpg -- 18.95kb -> 18.78kb (0.9%)
/static/endchat1.jpg -- 24.39kb -> 24.32kb (0.32%)
/static/gifs/giphy.gif -- 613.16kb -> 612.93kb (0.04%)

Signed-off-by: ImgBotApp <[email protected]>
[ImgBot] Optimize images
@Vyvy-vi Vyvy-vi marked this pull request as ready for review November 16, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants