Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Git Hash for ADflow #214

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Working Git Hash for ADflow #214

wants to merge 2 commits into from

Conversation

akleb
Copy link
Contributor

@akleb akleb commented Apr 18, 2022

Purpose

There was concern in this pyspline PR that repos like ADflow would not be able to import the shared object library in the __init__.py file like pyspline because it is normally handled by MExt. I made what seems to me to be a working example here. I think more discussion about specific formatting for this process should be done in the pyspline discussion.

Expected time until merged

a couple weeks, probably want pyspline discussion done first.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@akleb akleb requested a review from a team as a code owner April 18, 2022 19:08
@akleb akleb requested review from joanibal and sseraj April 18, 2022 19:08
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #214 (a10d8ec) into main (99bb3b2) will decrease coverage by 0.58%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   41.35%   40.77%   -0.59%     
==========================================
  Files          13       14       +1     
  Lines        3794     3799       +5     
==========================================
- Hits         1569     1549      -20     
- Misses       2225     2250      +25     
Impacted Files Coverage Δ
adflow/fortranVersion.py 50.00% <50.00%> (ø)
adflow/__init__.py 100.00% <100.00%> (ø)
adflow/pyADflow_C.py 18.64% <0.00%> (-10.17%) ⬇️
adflow/pyADflow.py 67.64% <0.00%> (-0.78%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sseraj sseraj removed their request for review May 10, 2022 13:34
@ewu63
Copy link
Collaborator

ewu63 commented Oct 11, 2022

TODOs:

  • fix the complex build
  • finalize implementation (based on the pyspline PR)
  • add printing of the version in the header printed on ADflow call

@eirikurj
Copy link
Contributor

eirikurj commented Nov 7, 2022

Putting this in draft for now until we converge on mdolab/pyspline#41

@eirikurj eirikurj marked this pull request as draft November 7, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants