Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface output for forces in lift and drag directions #358

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented May 31, 2024

Purpose

This PR adds force coefficients per unit area projected in the lift and drag directions as surface output variables. Here is an example of the force in the drag direction for the MACH tutorial wing case:
force_in_drag_dir

It would be great if the reviewers could test this on their own cases.

Expected time until merged

2-3 weeks

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

No tests, but I tried this on wing and full aircraft cases and the outputs made sense.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner May 31, 2024 18:09
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.13%. Comparing base (6706920) to head (558a5ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   41.13%   41.13%           
=======================================
  Files          13       13           
  Lines        4108     4108           
=======================================
  Hits         1690     1690           
  Misses       2418     2418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArshSaja ArshSaja requested a review from sanjan98 July 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants