Add typing to validate_types decorator
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That sounds about right! The branch is merged now. |
mdomke
requested changes
Sep 21, 2023
For users of `ULID.from_*`, pylance indicates "partially unknown".
johnpaulett
force-pushed
the
typing-avoid-unknowns
branch
from
4c71e32
to
912e3e2
Compare
mdomke
approved these changes
Sep 21, 2023
|
@mdomke no rush, but would it be possible to cut a 2.3.0 release to include this and the other recent PRs? |
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users of
ULID.from_*, pylance indicates "partially unknown", e.g.:This PR tweaks
validate_typesto avoid that error.Also fixes typing warning for
__lt__and__eq__.