EPIC CV2-4441 - Articles #1951
EPIC CV2-4441 - Articles #1951
Conversation
Add new rail item for Articles Add tooltip to new rail item Add new navigation item “Explainers” for articles Reference: CV2-4501
amoedoamorim
requested review from
brianfleming,
danielevalverde and
sarahkeh
as code owners
List explainers under a new route /:team/articles/explainers. Requires Check API branch with the same name. - New component <Articles /> (and unit tests) which basically reuses other existing components - the idea is to use it for both explainers (this PR) and fact-checks (coming soon in another PR). - New component <Explainers /> that uses <Articles />. - Extracted the paginator from the feed clusters page as a standalone component <Paginator /> now used for articles and feeds. Reference: CV2-4500.
|
@caiosba I noticed while reviewing the recent updates to this branch that the new explainers list, the filter bar when the page is first loaded incorrectly has the 
|
I'll fix it! |
@brianfleming , I fixed it in this commit in another branch (fact-checks list): cdbf8eb. Basically the issue is that the condition to hide the buttons should be one filter (since article type is always present), not zero. The fix is for the |
List of fact-checks. Reference: CV2-4145.
* change 404 language to be less cutsey * add new beige button themes and apply to side navigation new buttons * update beige button colors * add missing classname in main button for new beige color * fix some consistency issues on the side navigation and restyle custom lists to have an easier to read layout * add missing beige prop type to main button
…d make enhancements (#1959) * Remove Claim and Rating from Add Item dialog Remove the Claim text field from the Add item dialog Remove the rating selection from the Add item dialog Re-title Dialog and button from Add item to Add Media Rename button from 'Add Item' to 'Add Media' Reference: CV2-4450
* Added creation forms for Explainers and Fact Checks ExplainerForm handles the mutations for creating or updating an explainer article. The explainer article requires title, summary, and language. Tags and url are optional. ClaimAndFacCheckForm handles the mutations for creating or upating a fact check. A claim description is first required before removing the overlay for the Fact Check section. Form components were mostly taken from the MediaFactCheck component. An update was made to the LnaguagePicker to allow for the field to be required for the explainer. cv2-4498 and cv2-4447 * Connect forms with links on the Articles page, made necessary updates to styling and passed down team info needed for saving any new Form * Request pr changes for input forms Opening another slideout from the New Article menu will close the current slideout. Menu will close when a selection is made. Flash message now uses the useContext hook Changed error handling failed saves, will use the API error and fallback on a generic message Specified the possible strings for articleType and mode values Removed the reliance on values for TranslatedMessages which was preventing the messages from truly being translated Removed error value that was left over from testing * removed console statement * Added team tags for the forms, made additional fixes to simplify value assignments. Added tag_texts to Projects query since the New Article button lives within that object * saving the wrong info
|
Just wanted to flag here because I am not sure who is going to take this on, or if it fell between the cracks. but I noticed that the cards are not pulling in the tags. They show up if you add them during the article creation process, but not in the list itself and you can't add them via the list. |
Hum, weird... I implemented setting tags for explainers and fact-checks from the cards... are you using the epic branch for the API side too, @brianfleming ? |
yeah, just doubled checked and made sure I pulled latest on that branch. Does it work for you? i can show you on the front end call momentarily |
Yeah, it works for me. OK, let's talk in the call. |
…into epic/CV2-4441-articles
See Figma designs in referenced Jira ticket for details. But the main ideas here are: - Delete the left sidebar from the item page (the one with claim and fact-check) - Add a new right sidebar called "Articles" - In that sidebar, for items with no articles (so, no explainers and no fact-check), show a button to create new article and list articles to be applied to item - Clicking on an article (explainer or fact-check) adds it to the current item - The articles in that right sidebar have a hover style - When the item has an article, the right sidebar shows only the "New article" button - this case is going to be handled by another ticket Reference: CV2-4626
* Implement search existing article button and slideout * add unit test * add BEM class * Add empty state for article search --------- Co-authored-by: Brian Fleming <[email protected]>
* Changes for editing a fact check and explainer Added a new RatingSelector item Added created_by date Added items needed for editing to cards Removed reliance on project_media * Add edit to form, added additional info in edit form edit status and publish values for fact checks set description as summary for fact checks claim is now claim_description verification_statuses now sent to create form * Added error checking for required fields Removed trash for now, hid the footer for editing Publish status only shows when there is an associated project media and the link is updated to go from the Articles list Removal of Created By, name is added for Last Saved: Pulled everything from ArticlesCard except onClick event to Articles file The save after editing a field now uses existing FactCheck/Claim/Explainer object + new field value, rather than just the state value, to fix a most recently updated field not saving sometimes Removed unused fields added to ArticleCard * remove testing console log * click on general card area, not tag buttons, added safe nav * click on article without having to close form first * Paired code review --------- Co-authored-by: Brian Fleming <[email protected]> Co-authored-by: Alexandre Amorim <[email protected]>
* start to clean up sandbox for cluster card. Allow a fact-check link without a description in cluster cards * add optional link and tags to article card in sandbox * add published to sandbox article card and improve unread visuals * hide language in shared feed on article card * Cards fixes and tweaks * Apply Brian's requested changes in his branch/PR and include CV2-4885 scope * testing against api branch of same name * sha512 instead of sha1 in package lock file * Fix workspace ClusterCard rating in Sandbox; Fix ClusterCard unit test; Appease a couple of warnings * improve sandbox cluster card to show zero requests in tipline lists and always show requests in shared feed * include the Articles concept in cluster card sandbox --------- Co-authored-by: Alexandre Amorim <[email protected]>
Managing articles from item page. --------- Co-authored-by: Alexandre Amorim <[email protected]> Co-authored-by: Brian Fleming <[email protected]> Co-authored-by: Caio <[email protected]>
* share some more styles for cards with new media article card * tweak slideout width * update copy on articles list alert * Add word article to slideout titles * better cursor behavior for cards
* created remove article button * button with confirmation modal * Added Remove Article button, currently just for Explainer, will add Fact Check next * added remove fact check by updating claim description project media to null * fixed styling issues after fixing merge conflict * wrong type for id
Delete/Update the current failing tests for claim and fact-check Create fact-check from the list view and make sure it appears in the list after reload Create explainer from the list view and make sure it appears in the list after reload Add fact-check to an item on the item page and go to report page Add explainer to an item on the item page Add new classes/id's for the tests Reference:CV2-4883
* Use consistent empty state for tags in setttings area and make table look like the rules table more * Clean up privacy requests while reviewing Articles [CV2-4874] * tweak empty annotations message * update scrolling on articles list * add tooltip for remove article button * Change bulk actions language and limit count to the button so the user isn't confused with the pager * add cancel button to existing article slideout * add scroll indicator to articles list on media cluster page * no need to close drawer on media item pages now that we have 2 columns * All to all media in nav and header * minor updates to new fact-check slideout to better match designs
* Use ArticleCard in article lists powered by Search component * Play it again, Travis * WIP * Imported and Published articles lists * small copy consistency updates for claim & fact-check wording --------- Co-authored-by: Brian Fleming <[email protected]>
Description
This is the branch to consolidate all features from the CV2-4441 Articles EPIC.
Main changes for each ticket:
API Epic PR:
meedan/check-api#1903
CV2-4501 (Daniele)
Add new rail item for Articles
Add tooltip to new rail item
Add new navigation item “Explainers” for articles
Type of change
How has this been tested?
CV2-4501 (Daniele)
Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.
Things to pay attention to during code review
CV2-4501 (Daniele)
Please describe parts of the change that require extra attention during code review, for example: