First attempt at tag based deploy workflow. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonoransun
requested review from
DGaffney,
computermacgyver and
skyemeedan
as code owners
skyemeedan
reviewed
Dec 18, 2023
| -H "Accept: application/vnd.github+json" \ | ||
| -H "Authorization: Bearer ${{ secrets.SYSOPS_RW_GITHUB_TOKEN }}" \ | ||
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| https://api.github.com/repos/meedan/sysops/actions/workflows/deploy_${{ github.event.repository.name }}.yml/dispatches \ |
There was a problem hiding this comment.
Does this trigger script to look at the tagged repository and redeploy all of the associated services? Are we assuming that the workflow is "merge to main, run in QA for a while, then tag to trigger live release?" i.e. the images to be deployed are already build and pushed to ECR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft attempt at a tag based Live deployment workflow for Presto.
One remaining question mark is how to tie the image to the tag, as we currently have
masterand specific revisionshas as identifier options; no tag names.We could just deploy master when tagged, as it should always be the latest that we deploy? But that's hacky and will have unintended side effects at some point in the future. I'll look at this again once I've got a bit more brain to apply...