Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cv2 4242 implement sscd in image.py alongside pdq and create a new branch for it #59

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Cv2 4242 implement sscd in image.py alongside pdq and create a new branch for it #59

wants to merge 17 commits into from

Conversation

ahmednasserswe
Copy link
Contributor

implement both sscd and pdq together in image.py

@ahmednasserswe
Create image_sscd.py
2a5f4b2
@ahmednasserswe
changes on .gitignore
bf54c56
@ahmednasserswe
Create test_image_sscd.py
50318d6
@ahmednasserswe
adding 'img/presto_flowchart.jpg'
b5f4dcc
@ahmednasserswe
putting sscd normalization masks as variables imagenet_normalization_…
5f30ab0 
…mean and imagenet_normalization_std
@ahmednasserswe
Delete .idea/.DS_Store
3918aa0
@ahmednasserswe
upcasing imagenet normalization masks' constants
1a7b01b
@ahmednasserswe
specific exception handle for reading sscd model's file not found exc…
80ae3fd 
…eption
@ahmednasserswe
Changing FIleNotFoundError to ValueError
a012808
@ahmednasserswe
changes on genericitem to contain both sscd vector and pdq hash
9f54891
@ahmednasserswe
changes on image.py to calculate both sscd and pdq returning generici…
b842775 
…tem in `process`
@ahmednasserswe
fixing the name of the function to compute_sscd
75544d6
@ahmednasserswe
removing test_image_sscd and combining tests of sscd and pdq in test_…
7091f20 
…image
DGaffney
DGaffney requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@DGaffney DGaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few points to check in on!

lib/model/image.py Outdated Show resolved Hide resolved
lib/model/image.py Outdated Show resolved Hide resolved
lib/model/image_sscd.py Outdated Show resolved Hide resolved
lib/schemas.py Outdated Show resolved Hide resolved
computermacgyver
computermacgyver reviewed Feb 12, 2024
View reviewed changes
lib/model/image_sscd.py Outdated Show resolved Hide resolved
lib/model/image.py Outdated Show resolved Hide resolved
lib/model/image.py Outdated Show resolved Hide resolved
@computermacgyver computermacgyver mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@computermacgyver computermacgyver computermacgyver left review comments

@DGaffney DGaffney DGaffney requested changes

@skyemeedan skyemeedan Awaiting requested review from skyemeedan skyemeedan is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmednasserswe @DGaffney @computermacgyver