Add a location constraint for bucket creation. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonoransun
requested review from
DGaffney,
computermacgyver and
skyemeedan
as code owners
skyemeedan
reviewed
Mar 8, 2024
| @@ -21,7 +21,7 @@ def upload_file_to_s3(bucket: str, filename: str): | |||
| except ClientError as e: | |||
| if e.response['Error']['Code'] == 'NoSuchBucket' or int(e.response['Error']['Code']) in [403, 404]: | |||
| # Create the bucket since it does not exist | |||
| s3_client.create_bucket(Bucket=bucket) | |||
| s3_client.create_bucket(Bucket=bucket, CreateBucketConfiguration={'LocationConstraint': region}) | |||
There was a problem hiding this comment.
maybe we should set this to default to eu-west-1 if the paramter is missing in the env? I think that would make line 11 region = os.getenv('AWS_DEFAULT_REGION', 'eu-west-1')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only region where a location constraint is not required is us-east-1.