Dynamic gitlab runner registration #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (1)
- home/.chezmoi.yaml.tmpl (1)
Files ignored due to filter (1)
- software.yml
Files not summarized due to errors (1)
- home/.chezmoi.yaml.tmpl (nothing obtained from openai)
Files not reviewed due to errors (1)
- home/.chezmoi.yaml.tmpl (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
Hey @enggnr --- is this ready to be merged? What issue does it address? |
There was a problem hiding this comment.
Files selected (1)
- home/.chezmoi.yaml.tmpl (1)
Files ignored due to filter (1)
- software.yml
Files not summarized due to errors (1)
- home/.chezmoi.yaml.tmpl (nothing obtained from openai)
Files not reviewed due to errors (1)
- home/.chezmoi.yaml.tmpl (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
@ProfessorManhattan, a token was manually added to the secrets to configure Gitlab runner. It was using the now deprecated method of registering runners. This change needs just the Gitlab API token (with right permissions of course) to register a runner at the Group level. It also uses the new method of registering runners. |
There was a problem hiding this comment.
Files selected (1)
- docs/customization/secrets.md (1)
Files not summarized due to errors (1)
- docs/customization/secrets.md (nothing obtained from openai)
Files not reviewed due to errors (1)
- docs/customization/secrets.md (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This change provides the ability to generate Runner auth token for Gitlab runner registration
What is the current behavior? (You can also link to an open issue here)
Gitlab runner registration token is provided manually. This method is deprecated and will be removed in the future
Other information:
Fixes Dynamically Acquire GitLab Runner Token #134.