Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to install elastic agent #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Script to install elastic agent #57

wants to merge 1 commit into from

Conversation

enggnr
Copy link
Contributor

@enggnr enggnr commented Jun 28, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR provides a script that conditionally enrolls elastic agent with Elastic fleet server

  • What is the current behavior? (You can also link to an open issue here)
    Elastic agent is not automatically enrolled

  • What is the new behavior (if this is a feature change)?
    Fixes Add device with elastic-agent #26

@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

🤖 OpenAI

Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.
Files not summarized due to errors (2)

Failed to summarize

  • home/.chezmoi.yaml.tmpl (nothing obtained from openai)
  • home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl (nothing obtained from openai)

In the recent run, only the files that changed from the base of the PR and between 2dfb30a3b8eb3da1335bc095df468fca9934c8a8 and 06c0429dc596cfc40db8f5062080cb8051dcac96 commits were reviewed.

Files not reviewed due to errors in the recent run (2)

Failed to review in the last run

  • home/.chezmoi.yaml.tmpl (no response)
  • home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl (no response)

ProfessorManhattan
ProfessorManhattan reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@ProfessorManhattan ProfessorManhattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple requests

home/.chezmoi.yaml.tmpl Show resolved Hide resolved
home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl Show resolved Hide resolved
ProfessorManhattan
ProfessorManhattan requested changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@ProfessorManhattan ProfessorManhattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments on this one

ProfessorManhattan
ProfessorManhattan requested changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@ProfessorManhattan ProfessorManhattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install Elastic Agent as well.

home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl Show resolved Hide resolved
enggnr
enggnr commented Jul 10, 2023
View reviewed changes
Copy link
Contributor Author

@enggnr enggnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments incorporated

enggnr
enggnr commented Jul 19, 2023
View reviewed changes
Copy link
Contributor Author

@enggnr enggnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I didn't push the changes, should be good now.

ProfessorManhattan
ProfessorManhattan requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@ProfessorManhattan ProfessorManhattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to use SRV records / auto-discovery like glusterfs / etcd

home/.chezmoi.yaml.tmpl Show resolved Hide resolved
home/.chezmoiscripts/universal/run_onchange_after_57-elastic-agent.sh.tmpl Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorManhattan ProfessorManhattan ProfessorManhattan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add device with elastic-agent
2 participants
@enggnr @ProfessorManhattan