Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks #55

Merged
merged 5 commits into from
Mar 10, 2013
Merged

Tweaks #55

merged 5 commits into from
Mar 10, 2013

Conversation

fredwu
Copy link
Contributor

@fredwu fredwu commented Feb 8, 2013

A couple of tweaks:

  • Fixed the broken default callback argument.
  • Fixed the default value for chosenOptions.
  • Fixed the bug where the success callback is called multiple times.
  • Have field passed into the callback function as it's very useful.
  • Simplified the JS by getting rid the usage of if not.

This PR contains the fix to #30 (which is covered by PR #51).

@fredwu
Copy link
Contributor Author

fredwu commented Feb 8, 2013

This PR also removes the excessive amount of whitespaces in the coffee source. But for the benefit of diffing, you could view the changes without whitespaces here. :)

@fredwu
Copy link
Contributor Author

fredwu commented Mar 9, 2013

Hi @meltingice, any chance to review this PR yet? :)

meltingice added a commit that referenced this pull request Mar 10, 2013
@meltingice meltingice merged commit a7ff8fc into meltingice:master Mar 10, 2013
michaelperrin pushed a commit to michaelperrin/ajax-chosen that referenced this pull request Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants