Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve prepare application and PDS solution #3236

Merged
merged 13 commits into from
Jul 3, 2024

Conversation

- added storage variables
- added additional tags to skopeo wrapper
- added second profile to prepare setup for sechub server test
@lorriborri lorriborri marked this pull request as ready for review June 21, 2024 14:15
# Conflicts:
#	sechub-pds/src/test/java/com/mercedesbenz/sechub/pds/PDSStartupAssertEnvironmentVariablesUsedTest.java
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but I have found some parts to enhance.

@lorriborri lorriborri force-pushed the feature-3233-improve-pds-solution-prepare branch from d7db982 to cd87ca8 Compare June 24, 2024 13:27
@lorriborri lorriborri requested a review from de-jcup June 24, 2024 13:29
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found still some parts.

@lorriborri lorriborri force-pushed the feature-3233-improve-pds-solution-prepare branch from ce907c7 to 06effac Compare June 26, 2024 10:44
@lorriborri lorriborri force-pushed the feature-3233-improve-pds-solution-prepare branch from 06effac to 4529716 Compare June 26, 2024 11:39
@lorriborri lorriborri requested a review from de-jcup June 26, 2024 14:32
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lorriborri lorriborri merged commit e0bb007 into develop Jul 3, 2024
2 checks passed
@lorriborri lorriborri deleted the feature-3233-improve-pds-solution-prepare branch July 3, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants