-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve prepare application and PDS solution #3236
Improve prepare application and PDS solution #3236
Conversation
lorriborri
commented
Jun 20, 2024
•
edited
Loading
edited
- closes Improve PDS Solution for Prepare for new environment variable handling #3233
- closes Prepare Wrapper Application add Tag to docker archive #3234
- closes Prepare wrapper make git clone into repository name #3240
- added storage variables - added additional tags to skopeo wrapper - added second profile to prepare setup for sechub server test
# Conflicts: # sechub-pds/src/test/java/com/mercedesbenz/sechub/pds/PDSStartupAssertEnvironmentVariablesUsedTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, but I have found some parts to enhance.
...ain/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoLocationConverter.java
Outdated
Show resolved
Hide resolved
...pare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoWrapper.java
Show resolved
Hide resolved
.../src/test/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoWrapperTest.java
Show resolved
Hide resolved
...c/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/GitPrepareWrapperModule.java
Outdated
Show resolved
Hide resolved
d7db982
to
cd87ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found still some parts.
...ain/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoLocationConverter.java
Show resolved
Hide resolved
...pare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoWrapper.java
Outdated
Show resolved
Hide resolved
.../test/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/GitLocationConverterTest.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/mercedesbenz/sechub/wrapper/prepare/modules/git/GitLocationConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoLocationConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/com/mercedesbenz/sechub/wrapper/prepare/modules/skopeo/SkopeoLocationConverter.java
Outdated
Show resolved
Hide resolved
ce907c7
to
06effac
Compare
06effac
to
4529716
Compare
# Conflicts: # sechub-wrapper-prepare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/cli/PrepareWrapperCLI.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.