Feature 3255 solve PDS prepare s3 storage problem #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-jcup
force-pushed
the
feature-3255-solve-pds-prepare-s3-storage-problem
branch
from
e270f1a
to
99b3a50
Compare
- main problem was that transfer managers were not shutdown when no longer needed - removed also old convienence getter method for job storage (was only used by one test and one implementation) - renamed getJobStorage to createJobStorage and mentioned in javadoc the close method must be called after no longer need of object - close job storage on every point (PDS, SecHub and also prepare wrapper when no longer needed
- fixes failing test, the method and the injected object are not necessary
de-jcup
changed the title
lorriborri
requested changes
Jul 2, 2024
...m/mercedesbenz/sechub/integrationtest/scenario22/PDSPrepareIntegrationScenario22IntTest.java
Outdated
Show resolved
Hide resolved
...m/mercedesbenz/sechub/integrationtest/scenario22/PDSPrepareIntegrationScenario22IntTest.java
Outdated
Show resolved
Hide resolved
- only project6 integration test was executed before - changed this, now multi project test is executed instead again
lorriborri
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR