Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy setup to prepare wrapper #3269

Merged
merged 9 commits into from
Jul 5, 2024
Merged

Add proxy setup to prepare wrapper #3269

merged 9 commits into from
Jul 5, 2024

Conversation

lorriborri
Copy link
Member

@lorriborri lorriborri requested a review from de-jcup July 2, 2024 11:12
@lorriborri lorriborri marked this pull request as ready for review July 3, 2024 14:31
@lorriborri lorriborri force-pushed the feature-3260-add-proxy-to-prepare-wrapper branch from 48cbfb3 to 016c971 Compare July 3, 2024 14:36
@lorriborri lorriborri force-pushed the feature-3260-add-proxy-to-prepare-wrapper branch from 016c971 to 8d1120b Compare July 4, 2024 07:48
@lorriborri lorriborri requested review from winzj and removed request for de-jcup July 4, 2024 09:12
@lorriborri lorriborri assigned winzj and unassigned de-jcup Jul 4, 2024
winzj
winzj requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

I have some ideas, but most of them are more optional from my perspective. Please have a look at the comments.

sechub-pds-solutions/prepare/docker/pds-config.json Show resolved Hide resolved
sechub-pds-solutions/prepare/env Outdated Show resolved Hide resolved
sechub-pds-solutions/prepare/helm/pds-prepare/templates/deployment.yaml Outdated Show resolved Hide resolved
sechub-pds-solutions/prepare/helm/pds-prepare/values.yaml Show resolved Hide resolved
...re/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/cli/PrepareWrapperKeyConstants.java Outdated Show resolved Hide resolved
...re/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/cli/PrepareWrapperKeyConstants.java Outdated Show resolved Hide resolved
...repare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/PrepareWrapperProxySupport.java Outdated Show resolved Hide resolved
...repare/src/main/java/com/mercedesbenz/sechub/wrapper/prepare/PrepareWrapperProxySupport.java Outdated Show resolved Hide resolved
@lorriborri lorriborri force-pushed the feature-3260-add-proxy-to-prepare-wrapper branch from 4c9c393 to 2c80e42 Compare July 5, 2024 09:01
@lorriborri lorriborri requested a review from winzj July 5, 2024 09:32
winzj
winzj approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

I just found a typo in the env file.

sechub-pds-solutions/prepare/env Outdated Show resolved Hide resolved
@lorriborri lorriborri force-pushed the feature-3260-add-proxy-to-prepare-wrapper branch from c3fede8 to 1b98895 Compare July 5, 2024 10:09
@lorriborri lorriborri merged commit 00a1687 into develop Jul 5, 2024
2 checks passed
@lorriborri lorriborri deleted the feature-3260-add-proxy-to-prepare-wrapper branch July 5, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winzj winzj winzj approved these changes

Assignees

@lorriborri lorriborri

@winzj winzj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Proxy for Prepare Wrapper
3 participants
@lorriborri @winzj @de-jcup