Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vite Svelte warning #19

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Fix Vite Svelte warning #19

merged 5 commits into from
Mar 15, 2024

Conversation

mattpilott
Copy link
Contributor

Currently vite plugin svelte warns of the following.
[vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte.

It provides this link for details to resolve https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition

I have added the svelte export as instructed

@mattpilott
Copy link
Contributor Author

@metonym are you able to give this a quick look and merge if good?

@metonym
Copy link
Owner

metonym commented Mar 14, 2024

Hey, thanks for the ping. I'll take a look.

Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative – I updated the exports map to include the necessary mappings needed for TypeScript definitions, and direct .svelte imports.

@metonym metonym merged commit 6baabdc into metonym:master Mar 15, 2024
1 check passed
@metonym
Copy link
Owner

metonym commented Mar 15, 2024

@mattpilott Released in v0.7.0

@mattpilott
Copy link
Contributor Author

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants