Add on_config hooks to dap.providers #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfussenegger
commented
May 30, 2024
| Example: | ||
| >lua | ||
| local dap = require("dap") | ||
| dap.providers.on_config["dummy-noop"] = function(config) |
There was a problem hiding this comment.
I'm still not sure about the overall naming. Other options:
dap.ext.on_configanddap.ext.configsdap.ext.on_configanddap.ext.config_providersdap.config_providersanddap.config_hooks
I'd kinda like having a namespace because I have in mind of also adding variable-placeholder-processors and later on likely variable formatters for the REPL and widgets.
There was a problem hiding this comment.
Moving it to dap.listeners.on_config: #1248
Should solve #720
Makes the implementation a bit simpler. Given that the function is called from a coroutine it is still possible to use coroutine.running(), coroutine.resume() and coroutine.yield() within it for async operations.
|
I'm going ahead and merge this but this doesn't mean that the API is final and I'd still very much appreciate feedback about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.