fix TFLOPs calculation #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when GQA used, we observe right TFLOPs after this fix. when GQA is not used, huge difference in TFLOPs is solved with selective recompute . some other minor difference will also be observed as logits macs also added.
polisettyvarma
requested review from
tjruwase,
conglongli,
awan-10,
eltonzheng,
duli2012,
mrwyattii,
arashb,
xiaoxiawu-microsoft and
GuanhuaWang
as code owners
Closed
|
@romankap please review this |
|
@polisettyvarma, you didn't add me as a reviewer, but code changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when GQA used, we observe right TFLOPs after this fix.
when GQA is not used, huge difference in TFLOPs is solved for selective recompute granularity.
some other minor difference will also be observed as logits macs also added.