[PT Run > Date and Time plugin] Setting First week of year and First day of week
#33406
+483
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htcfreek
changed the title
Setting for First week and First day of week
htcfreek
added
Idea-Enhancement
htcfreek
changed the title
Setting for First week and First day of weekFirst week of year and First day of week
htcfreek
commented
Jun 19, 2024
...launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate.UnitTests/TimeAndDateHelperTests.cs
Outdated
Show resolved
Hide resolved
...launcher/Plugins/Microsoft.PowerToys.Run.Plugin.TimeDate.UnitTests/TimeAndDateHelperTests.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
htcfreek
added
the
Needs-Review
htcfreek
commented
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR implements two new plugin settings:
First week of year
First day of week
PR Checklist
Detailed Description of the Pull Request / Additional comments
For both settings the users can decide to be in sync with the system settings (default) or to use their own setting. The order of days for the
first day of weeksetting is based on the current system culture.PT Run respects these settings for the relevant results:
Validation Steps Performed
Manual tested and running unit tests.